-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: update github actions with logical sequence of tests #500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #500 +/- ##
===========================================
- Coverage 71.30% 71.11% -0.19%
===========================================
Files 56 55 -1
Lines 9374 9279 -95
===========================================
- Hits 6684 6599 -85
+ Misses 2690 2680 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kinda doesn't work as expected. Gonna close it for a while so nobody reviews it, but we can take a deeper look in the short-future. Please don't delete branch |
fb77af8
to
712920f
Compare
After almost 4 hours spent on figuring out how the GitHub actions works, I believe I finally finished this one!!
Final comment: This was the PR #500 :) |
Also, I wonder why the tests on python 3.12 are much slower than the 3.8, it should be the opposite. |
374eefd
to
e1c6d6f
Compare
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant) (not relevant)Current behavior
Important note: The skip-if-draft (#362) job is not working currently. I see some execution times up to 12 hours on our organization account, let's try to solve it (e.g. https://github.com/RocketPy-Team/RocketPy/actions/runs/7071607213)
New behavior
Breaking change
Additional information
Extra reading: